Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: add deployment to GH releases and S3 #5371

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented Feb 23, 2021

Purpose and Motivation

Further implementation of #5261

This PR adds deployment steps for our GitHub Actions workflow, making it pretty much complete for Linux and macOS.

Here's an example of a build from this branch: commit and tag.
(it seems that the release artifacts have been since overwritten by Travis... but I can attest they were uploaded properly beforehand)

Here are some implementation notes for a possible discussion before merging:

  • both GH release deployment for releases, as well as S3 upload for all commits is implemented in a single job
  • the deployment job runs either in the main repo, or for tagged commits (in all repos/forks)
  • for GH release uploads I used softprops' action, since the most popular action for that purpose seems unmaintained...
    • this action sets the release author to "github-actions" (previously it was set to @scztt )
    • I've set it to create "draft release", since we need to usually perform some manual tasks before making the release official (namely sign macOS binaries)
    • the action uses emoji in its console output. Probably not a big deal, but I wanted to point this out... 🤷‍♂️
  • s3 deployment is triggered for every commit (but not on tags) on the main repo; it checks for existence of the secret key in the repository settings and thus will not be triggered when running in a fork

Types of changes

  • New feature

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

@dyfer dyfer added the comp: CI/CD continuous integration and deployment (github actions, etc.) label Feb 23, 2021
@dyfer dyfer requested a review from mossheim February 23, 2021 00:16
@dyfer dyfer mentioned this pull request Feb 23, 2021
4 tasks
Copy link
Contributor

@mossheim mossheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mossheim mossheim merged commit 3ea596a into develop Feb 23, 2021
@mossheim mossheim deleted the topic/gha-deployment-clean branch February 23, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: CI/CD continuous integration and deployment (github actions, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants