Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLPF.schelp: adjust example to avoid exploding filter due to frequency folding when modulated. #2053

Merged
merged 2 commits into from
May 9, 2016

Conversation

miczac
Copy link
Contributor

@miczac miczac commented May 8, 2016

Signed-off-by: Michael Zacherl github-mz01@blauwurf.info

* fixed SinOsc helpfile

* Added closeWhenDone to .cue

* add args for Tdef.fork and .play in help file.

* remove obsolete SCView subclass

* add missing args to help file

* change link to Republic to just text.

* LFSaw.schelp: Note and example for special initial-phase behaviour

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>
@@ -42,20 +42,23 @@ Examples::

code::

{ RLPF.ar(Saw.ar(200, 0.1), FSinOsc.kr(XLine.kr(0.7, 300, 20), 0, 3600, 4000), 0.2) }.play;
// don't go too fast - frequency folding will result in unexpected and LOUD filter behaviour!
{ RLPF.ar(Saw.ar(200, 0.1), FSinOsc.kr(XLine.kr(0.7, 95, 20).poll, 0, 3600, 4000), 0.2) }.play;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless intended, FSinOsc is a bad choice for FM as modulator, because its amplitude is not linear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I can't tell what's the original idea, but also, as I can see now, .kr is also a bad choice if going to 300 Hz.
I'll change the example to SinOsc.ar .

…and exploding filter.

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>
@crucialfelix crucialfelix added this to the 3.8 milestone May 9, 2016
@crucialfelix crucialfelix added the comp: help schelp documentation label May 9, 2016
@crucialfelix crucialfelix merged commit 3e8efc8 into supercollider:helpfile-fixing May 9, 2016
@miczac miczac deleted the rlpf_schelp branch May 11, 2016 01:20
crucialfelix pushed a commit that referenced this pull request May 11, 2016
* added Pmul arguments name & pattern

* prReadDirectoryFile private, added done as arg

* some rephrasing and simplification

* added rudimentary git helpfile

* fixed naming startframe & aSoundFile

* removed method::preferencesAction

This should go in the helpfile of: OSXPlatform:

method::preferencesAction
note::SCApp only!::

A function to evaluate when the SuperCollider preferences menu is selected.

code::
thisProcess.preferencesAction = { arg process; SCWindow.new.front; }
::

* added rudimentary Message helpfile

* Revert "LFSaw.schelp: Note and example for special initial-phase behaviour" (#2056)

This reverts commit 381a3ff which was based on a wrong assumption. All is well!

* RLPF.schelp: adjust example to avoid exploding filter due to frequency folding when modulated. (#2053)

* Helpfile fixing (#2042)

* fixed SinOsc helpfile

* Added closeWhenDone to .cue

* add args for Tdef.fork and .play in help file.

* remove obsolete SCView subclass

* add missing args to help file

* change link to Republic to just text.

* LFSaw.schelp: Note and example for special initial-phase behaviour

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>

* RLPF.schelp: replace FSinOsc with SinOsc to avoid erratic amplitudes and exploding filter.

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>

* Klank & DynKlank - better structure for examples (#2055)

* Klank.schelp: improved examples

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>

* DynKlank.schelp: corrected statement about realtime-ness of Dynklank, split up examples

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>

* Pulse.schelp: added missing .kr method, beautified examples

Signed-off-by: Michael Zacherl <github-mz01@blauwurf.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: help schelp documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants