Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"maxval" ignored by Buffer.plot #507

Closed
danstowell opened this issue Sep 16, 2012 · 2 comments
Closed

"maxval" ignored by Buffer.plot #507

danstowell opened this issue Sep 16, 2012 · 2 comments
Assignees
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs.

Comments

@danstowell
Copy link
Member

In current master, I can't seem to get Buffer.plot to choose its maxval properly:

// This works fine:
((0..31) / 4).plot(maxval: nil)


// This does not respect the request to find its own maxval
q = Buffer.alloc(s, 32)
q.setn(0, (0..31) / 4)
q.plot(maxval: nil)
@ghost ghost assigned telephon Sep 16, 2012
@danstowell
Copy link
Member Author

Also, maxval for Buffer (but not for Array) now fails to let the user specify different maxval for each channel:

// This works fine:
((0..31) / 4).plot(maxval: [20, 1], numChannels: 2)

// This does not respect the request for a different maxval for each channel
q = Buffer.alloc(s, 16, 2)
q.setn(0, (0..31) / 4)
q.plot(maxval: [20, 1])

@danstowell
Copy link
Member Author

I believe 57ca3e3 fixes these issues. If not please reopen...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that relate to unexpected/unwanted behavior. Don't use for PRs.
Projects
None yet
Development

No branches or pull requests

2 participants