BlitB3 -- fix oscillator freezing #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 30, 2016 15:25
sorry, my editor does this and I might as well get rid of them
|
looks good. also thanks for cleaning the code! |
|
How about merging this for 3.7.2, i.e. very soon? ;) Builds fine on VS and MinGW too... |
|
Hmm, reading some recent discussions on music-dsp, using floating point to keep track of phase increases the risk of phase drift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82 with smarter phase tracking. A few extra divides and multiplies per control period, but shouldn't be huge.
Sorry about the absurd diff, my editor removed a bunch of trailing whitespace. I didn't feel like turning it off because we might as well get rid of it.