Create assets with a script #186
Conversation
…mp) and a valid version tag. Might not work on macOS properly, because there's no readlink (install with brew/macports).
…ources() and adding more folders. Unifying the moving of tarball by using output_dir (which is currently HOME for macOS and package dir for Linux. Adding cleanup_source_dir() to remove versioned package directory. Removing unused function.
|
@snappizz @brianlheim it would be great if you could give some feedback on this, as I can not test it on macOS. |
|
I just realized, this will also fix #134. |
|
maybe this might be a workaround instead of |
…ectory as the script is in on macOS and Linux alike.
|
@telephon thanks a lot for the hint! I have corrected it (strange... searched for so long for a viable multi-architecture solution...). Feel free to test! |
|
Had the possibility to test this myself right now on macOS. |
…p() function. Revising getopts usage and defaulting to print_help in case of no input.
|
Also, I could add an option to sign the package with a given gpg key, if that's something @snappizz would be interested in doing when creating the assets. |
…ce tarball with a given ID/e-mail, when -s flag is provided.
|
Added non-mandatory function to sign tarballs with a given gpg ID/mail. |
package/create_package.sh
Outdated
| git clone $upstream | ||
| echo "Checking out version: Version-$version" | ||
| cd "$package_name" | ||
| git checkout "Version-$version" |
There was a problem hiding this comment.
@dvzrv This could be simplified to:
git clone $upstream --branch "Version-$version" --single-branch --recursive
That way checkout_external_libraries() wouldn't be needed anymore
There was a problem hiding this comment.
thanks! that simplfies it a lot! :)
package/create_package.sh
Outdated
| echo "$(cd "$(dirname "$0")" && pwd -P)" | ||
| } | ||
|
|
||
| remove_source_dir(){ |
There was a problem hiding this comment.
doesn't break, but is changed for consistency! :)
|
|
||
| rename_sources() { | ||
| cd "${source_dir}" | ||
| mv -v "${package_name}" "${package_name}-Version-${version}" |
There was a problem hiding this comment.
for consistency with core, i'd prefer the naming convention ${package_name}-${version}-Source
|
|
||
| compress_sources() { | ||
| cd "${source_dir}" | ||
| tar cvfz "${package_name}-Version-${version}.tar.tgz" \ |
|
changed my mind -- i'm just going to merge this now and address the requested changes in a separate PR. thanks david! |
Tweak names produced by package script, merge #186 into 3.10
This is an attempt to fix #184 by creating a script, that can be called from anywhere.
It will use
/tmpto create assets (in the form ofsc3-plugins-Version-x.x.x.tar.gz) and then place the finished tarball beneathpackage/.There is one pitfall: It uses
readlink -f(see get_absolute_path()), which doesn't seem to be around under macOS by default, but can be installed with the coreutils package using homebrew or macports.If you know of a valid alternative, let me know. As a workaround the script currently moves the tarball to $HOME on macOS and the package folder on Linux.
IMHO this is a much cleaner solution, than doing this in a potential working copy directly (as it is done in the SuperCollider repository).