Skip to content

Conversation

@DhavalGojiya
Copy link
Contributor

This PR fixes issue #26 where the --rm flag was incorrectly placed after the Docker image argument.

  • Corrects the argument order so --rm is applied before the image.
  • Adds a new CI workflow (container-remove-flag.yml) to test the redis-remove-container: true scenario across Redis versions 5, 6, 7.

This ensures containers start correctly and are automatically removed when requested.

- Fixes issue supercharge#26 where the '--rm' flag was applied after the image argument.
- Adds a new CI workflow 'container-remove-flag.yml' to test this scenario.
@marcuspoehls
Copy link
Member

@DhavalGojiya Hey Dhaval, thank you for the pull request. Very nice!

Out of interest: has AI generated the changes? (I’m asking because of all the added comments with emojis)

@DhavalGojiya
Copy link
Contributor Author

@DhavalGojiya Hey Dhaval, thank you for the pull request. Very nice!

Out of interest: has AI generated the changes? (I’m asking because of all the added comments with emojis)

Nope, I added everything myself. I am using "act" to test everything.

Actually, I've also created a similar GitHub Action for Apache Solr; you can check it in my repo.
I've copied some useful comment lines with emojis from there to here.
(Personally, I prefer using emojis in my open source PRs and for my own packages.)

@DhavalGojiya
Copy link
Contributor Author

@DhavalGojiya Hey Dhaval, thank you for the pull request. Very nice!

Out of interest: has AI generated the changes? (I’m asking because of all the added comments with emojis)

Please let me know if anything is missing or needs to be updated in PR.

@marcuspoehls marcuspoehls merged commit f21a04d into supercharge:main Nov 12, 2025
18 checks passed
@marcuspoehls
Copy link
Member

Thank you Dhaval!

@DhavalGojiya
Copy link
Contributor Author

Thank you Dhaval!

Welcome 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--rm flag added after image argument

2 participants