Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fish paths and arrays #163

Closed

Conversation

razvanazamfirei
Copy link

This PR introduces a feature enhancement allowing users to distinguish between arrays and path series in the fish shell when using xshe. Previously, xshe treated all array inputs as path series, appending the --path argument by default, which limited the usage of non-path arrays.

The update is backwards compatible. Users can now explicitly pass a regular array by using a nested array structure. For example, specifying [["array_element_1", "array_element_2"]] leads to the input being treated as a standard array and flattened when the environment variable is processed.

The PR updates dependencies and resolves several issues that arose from the update.

Closes #162. Furthermore, this PR closes #83 by implementing the XSHE_CONFIG environment variable.

@superatomic superatomic added the enhancement New feature or request label Nov 11, 2023
@superatomic
Copy link
Owner

Thank you so much for your PR! Your interest in this project means a lot to me.

Your issue raised in #162 is definitely one that should be fixed. From a quick glance, your PR looks very solid. I can also see that you've made quite a few improvements to my code, which I appreciate. Unfortunately, I'm a bit busy at the moment, so I might not have time to provide a complete review and get this merged for about a week. I apologize for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants