Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mixed media tweets #124

Closed
super-cooper opened this issue Oct 5, 2022 · 1 comment
Closed

Support mixed media tweets #124

super-cooper opened this issue Oct 5, 2022 · 1 comment
Labels
feature New feature or request good first issue Good for newcomers wontfix This will not be worked on

Comments

@super-cooper
Copy link
Owner

Is your feature request related to a problem? Please describe.
Twitter recently launched the ability to tweet multiple videos, or a combination of videos and pictures (see here for an example). Right now, Memebot seems to ignore these tweets.

Describe the solution you'd like
Memebot should embed multiple videos if the tweet contains multiple videos, and should react to the post appropriately for the number of media included.

Describe alternatives you've considered
N/A

Additional context
It seems unlikely that this depends on an update from Tweepy. Based on Twitter's API models, media seems sort of "agnostic," but we do make assumptions that tweets can have multiple images but only one video.

It does seem like we should get the reactions for free, since we don't check for what kind of media it is. However, they weren't created when someone posted a tweet with 4 videos. This could have been a coincidence related to intermittent Twitter API failures, which we are aware of. This could be improved by adding retries to API calls.

@super-cooper super-cooper added feature New feature or request good first issue Good for newcomers labels Oct 5, 2022
@super-cooper
Copy link
Owner Author

Some additional context worth considering: We ultimately decided not to post all the pictures of a tweet in Discord because it seemed spammy. Do we still think this? Does it make sense to embed videos iff the tweet only includes a single video? What is the best way to go about this? The solution may be easier when Discord allows bots to create custom UI elements.

@super-cooper super-cooper added the wontfix This will not be worked on label Sep 3, 2024
@super-cooper super-cooper closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Twitter Integration Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers wontfix This will not be worked on
Projects
Development

No branches or pull requests

1 participant