This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
fix: broken openapi specs/validation middleware #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertyfwu
requested review from
tomkit,
lucasmarshall,
asdfryan and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
albertyfwu
commented
Mar 10, 2023
| import { Router } from 'express'; | ||
| import customer from './customer'; | ||
| import integration from './integration'; | ||
|
|
||
| export default function init(app: Router): void { | ||
| const v1Router = Router(); | ||
|
|
||
| v1Router.use(openapiMiddleware('mgmt')); |
There was a problem hiding this comment.
this was the main issue that was not caused by ajv issues
lucasmarshall
approved these changes
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the issues here are due to ajv having a bug and interpreting
id: <uuid>as schema id even when they're used in examples. See stoplightio/spectral#2081Also, we seem to be mixing openapi 3.0.3 and 3.1.0 syntax for examples, which we should clean up at some point.