This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: sync standard objects for gong #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertyfwu
requested review from
tomkit,
lucasmarshall,
asdfryan and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
albertyfwu
commented
Jul 13, 2023
| data: toSyncConfigModel(syncConfig), | ||
| }); | ||
|
|
||
| await tx.syncConfigChange.create({ |
There was a problem hiding this comment.
this is a bug where we weren't creating ObjectSyncs when SyncConfig was updated with new objects.
albertyfwu
commented
Jul 13, 2023
| create: toSyncConfigModel(syncConfig), | ||
| update: toSyncConfigModel(syncConfig), | ||
|
|
||
| const upsertedSyncConfigModel = await this.#prisma.$transaction(async (tx) => { |
albertyfwu
commented
Jul 13, 2023
| await this.#prisma.syncConfig.deleteMany({ | ||
| where: { id, applicationId }, | ||
| }); | ||
| await this.#prisma.$transaction([ |
|
some thoughts:
|
tomkit
approved these changes
Jul 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports syncing standard objects for Gong.
Caveats:
Test Plan
[Describe test plan here]
Deployment instructions
[Add any special deployment instructions here]