Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redis): add TLS connection support to Redis FDW #370

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat(redis): add TLS connection support to Redis FDW #370

merged 1 commit into from
Nov 28, 2024
+77 −11

Conversation

burmecia
Copy link
Member

What kind of change does this PR introduce?

This PR is to add TLS connection support to Redis FDW, fix #368 .

What is the current behavior?

The current Redis FDW doesn't support TLS connection rediss:// in URL.

What is the new behavior?

Added TLS connection support to URL, also with optional insecure mode.

Additional context

  • because there is no way to upload files to Wrappers, the client certificate and custom root certificates are not supported when using TLS.
  • redis dependency lib is also upgraded to 0.27.5

@burmecia burmecia added redis Redis related issues enhancement New feature or request labels Nov 28, 2024
@burmecia burmecia requested review from imor and olirice November 28, 2024 07:51
@burmecia burmecia merged commit 156993d into main Nov 28, 2024
3 checks passed
@burmecia burmecia deleted the bo/feat/redis-tls branch November 28, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imor imor imor approved these changes

@olirice olirice Awaiting requested review from olirice

Assignees
No one assigned
Labels
enhancement New feature or request redis Redis related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis FDW doesn't support TLS redis connection urls
2 participants
@burmecia @imor