Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): Supabase Storage access issue #334

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

burmecia
Copy link
Member

What kind of change does this PR introduce?

This PR is to fix a S3 fdw access issue for Supabase Storage.

What is the current behavior?

The Supabase Storage is S3 compatible but it is using path-style URL access, but current S3 fdw only supports virtual-hosted–style URL requests. This will cause "request failed, service error" error.

What is the new behavior?

Added a new server option path_style_url to indicate using path-style URL or not, default is not. When using with Supabase Storage, this option needs to be set to 'true'.

Additional context

This PR also upgraded some dependencies for S3 fdw. Docs are also updated.

@burmecia burmecia requested a review from imor August 20, 2024 13:13
@burmecia burmecia added s3 S3 related issues bug Something isn't working labels Aug 20, 2024
@burmecia burmecia merged commit fe91635 into main Aug 20, 2024
3 checks passed
@burmecia burmecia deleted the bo/fix/compatible-s3 branch August 20, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s3 S3 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants