Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm): remove generated bindings.rs file #308

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

burmecia
Copy link
Member

@burmecia burmecia commented Jul 17, 2024

What kind of change does this PR introduce?

This PR to remove bindings.rs file for Wasm FDWs. The binding file is generated when building the Wasm FDW package, so it doesn't need to be in source control.

What is the current behavior?

N/A

What is the new behavior?

N/A

Additional context

This PR also did:

  • remove unused dependency bitflags
  • adjust compile order in CI as the bindings.rs file needs to be generated before run formatting and clippy.

@burmecia burmecia added the wasm label Jul 17, 2024
@burmecia burmecia requested a review from imor July 17, 2024 11:03
@burmecia burmecia merged commit c381519 into main Jul 18, 2024
2 checks passed
@burmecia burmecia deleted the bo/chore/remove-binding branch July 18, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants