Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clear tenant's cache on update or delete #309

Merged
merged 3 commits into from
Feb 20, 2024
Merged

feat: clear tenant's cache on update or delete #309

merged 3 commits into from
Feb 20, 2024

Conversation

abc3
Copy link
Member

@abc3 abc3 commented Feb 19, 2024

In this PR, we have introduced functionality to clear the entire internal cache for a specific tenant when an update or delete operation is performed through an API call. Additionally, we have disabled cache clearing when the pool is terminated.

@abc3 abc3 requested a review from chasers February 19, 2024 14:48
lib/supavisor.ex Outdated Show resolved Hide resolved
@chasers
Copy link
Contributor

chasers commented Feb 19, 2024

Is there a reason you're doing those inspects everywhere? Seems odd idk.

@abc3
Copy link
Member Author

abc3 commented Feb 19, 2024

I use inspect() to make valid map's key/value pairs, and then it will be possible to safely encode them to JSON.

@abc3 abc3 requested a review from a team February 19, 2024 17:55
Copy link
Contributor

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/supavisor.ex Outdated Show resolved Hide resolved
lib/supavisor/syn_handler.ex Outdated Show resolved Hide resolved
@abc3 abc3 merged commit 7281330 into main Feb 20, 2024
2 checks passed
@abc3 abc3 deleted the feat/drop-cache branch February 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants