Skip to content

Comments

chore: add ratchet rules to stop nesting components #42962

Merged
awaseem merged 6 commits intomasterfrom
aliwaseem/fe-2591-move-featuredintegrationsgrid-out-of-integrationspage
Feb 18, 2026
Merged

chore: add ratchet rules to stop nesting components #42962
awaseem merged 6 commits intomasterfrom
aliwaseem/fe-2591-move-featuredintegrationsgrid-out-of-integrationspage

Conversation

@awaseem
Copy link
Contributor

@awaseem awaseem commented Feb 17, 2026

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

The changes required for this React Doctor need more thought that I can hammer with AI. Just need to stop this from happening in the future with Ratchet rules

@awaseem awaseem requested a review from a team as a code owner February 17, 2026 20:33
@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
studio-self-hosted Ready Ready Preview, Comment Feb 18, 2026 4:50pm
studio-staging Ready Ready Preview, Comment Feb 18, 2026 4:50pm
7 Skipped Deployments
Project Deployment Actions Updated (UTC)
cms Ignored Ignored Feb 18, 2026 4:50pm
studio Ignored Ignored Feb 18, 2026 4:50pm
design-system Skipped Skipped Feb 18, 2026 4:50pm
docs Skipped Skipped Feb 18, 2026 4:50pm
learn Skipped Skipped Feb 18, 2026 4:50pm
ui-library Skipped Skipped Feb 18, 2026 4:50pm
zone-www-dot-com Skipped Skipped Feb 18, 2026 4:50pm

Request Review

@supabase
Copy link

supabase bot commented Feb 17, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Summary by CodeRabbit

  • Accessibility

    • Added alt text for images in authentication forms to improve screen reader support.
  • Chores

    • Enabled additional lint rules for component stability and accessibility.
    • Updated lint configs and scripts to apply those rules across the project.
    • Expanded lint baselines with file-specific import restrictions and adjusted rule tallies.

Walkthrough

This PR enables the react/no-unstable-nested-components rule in the studio ESLint config and ratchet script, and records its occurrences in apps/studio/.github/eslint-rule-baselines.json (including a new ruleFiles.no-restricted-imports mapping). jsx-a11y/alt-text is added as a warning in the ESLint config. The lint:ratchet npm script in apps/studio/package.json is updated to include the new rule. A small change in AuthProvidersForm/FormField.tsx adds alt attributes to rendered images and reorders imports.

Sequence Diagram(s)

(omitted)

Assessment against linked issues

Objective (grouped by issue) Addressed Explanation
Update ratchet rules to catch nested component definitions (FE-2591)

Out-of-scope changes

Code Change Explanation
Added alt attributes and reordered imports (apps/studio/components/interfaces/Auth/AuthProvidersForm/FormField.tsx) This is an accessibility/UI change unrelated to adding lint rules to detect nested components.
Enabled jsx-a11y/alt-text in ESLint config (apps/studio/eslint.config.cjs) This introduces an accessibility lint rule not required by FE-2591, which targets nested-component detection.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

🎭 Playwright Test Results

passed  135 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  140 tests across 19 suites
duration  13 minutes, 44 seconds
commit  e29327f

Flaky tests

Features › cron-jobs.spec.ts › Cron Jobs Integration › Cron Jobs CRUD Operations › can view cron jobs page

Skipped tests

Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@awaseem awaseem enabled auto-merge (squash) February 18, 2026 16:37
@awaseem awaseem disabled auto-merge February 18, 2026 16:47
@coveralls
Copy link

Coverage Status

coverage: 73.613%. remained the same
when pulling e29327f on aliwaseem/fe-2591-move-featuredintegrationsgrid-out-of-integrationspage
into 2dd75cb on master.

@awaseem awaseem merged commit c57c341 into master Feb 18, 2026
27 checks passed
@awaseem awaseem deleted the aliwaseem/fe-2591-move-featuredintegrationsgrid-out-of-integrationspage branch February 18, 2026 17:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

Braintrust eval report

Assistant (master-1771434664)

Score Average Improvements Regressions
Completeness 97.2% (+6pp) 2 🟢 -
Conciseness 0% (+0pp) - -
Goal Completion 94.4% (+1pp) 1 🟢 -
Tool Usage 100% (+0pp) - -
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 100% (+6pp) 1 🟢 -
Correctness 91.7% (+8pp) 1 🟢 -
Docs Faithfulness 61.1% (+3pp) 2 🟢 1 🔴
URL Validity 100% (+9pp) - -
Time_to_first_token 0.23tok (+0tok) 4 🟢 8 🔴
Llm_calls 8.5 (-0.14) 2 🟢 6 🔴
Tool_calls 3.36 (-0.31) 2 🟢 5 🔴
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 105032tok (-4485.17tok) 9 🟢 3 🔴
Prompt_cached_tokens 61873.78tok (-3569.78tok) 4 🟢 7 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 5947.22tok (+102.56tok) 6 🟢 6 🔴
Completion_reasoning_tokens 4529.78tok (+149.33tok) 6 🟢 6 🔴
Completion_accepted_prediction_tokens 0tok (+0tok) - -
Completion_rejected_prediction_tokens 0tok (+0tok) - -
Completion_audio_tokens 0tok (+0tok) - -
Total_tokens 110979.22tok (-4382.61tok) 7 🟢 5 🔴
Estimated_cost 0.02$ (0$) 5 🟢 7 🔴
Duration 45.56s (-7.83s) 10 🟢 2 🔴
Llm_duration 89.42s (-15.69s) 10 🟢 2 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants