fix: correct article usage for acronyms (an MFA, an SMS, an OTP)#42915
Merged
ChrisChinchilla merged 1 commit intosupabase:masterfrom Feb 18, 2026
Merged
Conversation
Fix incorrect indefinite article before acronyms that start with vowel sounds: - "a MFA" -> "an MFA" (pronounced "em-eff-ay") - "a SMS" -> "an SMS" (pronounced "ess-em-ess") - "a OTP" -> "an OTP" (pronounced "oh-tee-pee")
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
@yogeshwaran-c is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks for contributing to Supabase! ❤️ Our team will review your PR. A few tips for a smoother review process:
|
github-actions
bot
added
the
documentation
Contributor
|
No actionable comments were generated in the recent review. 🎉 Summary by CodeRabbit
WalkthroughThis pull request contains minor documentation and comment corrections across four files. Documentation files in Comment |
ChrisChinchilla
approved these changes
Feb 18, 2026
Contributor
ChrisChinchilla
left a comment
ChrisChinchilla
left a comment
There was a problem hiding this comment.
Thanks @yogeshwaran-c
ivasilov
approved these changes
Feb 18, 2026
Contributor
Braintrust eval report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Documentation / text fix (grammar)
What is the current behavior?
Several places in the codebase use "a" before acronyms that start with vowel sounds, which is grammatically incorrect:
What is the new behavior?
Corrected to use "an" before acronyms with vowel sounds:
Files changed
apps/studio/data/profile/mfa-challenge-and-verify-mutation.ts- comment fixapps/docs/content/guides/platform/multi-factor-authentication.mdx- user-facing docsapps/docs/docs/ref/javascript/v1/upgrade-guide.mdx- code comment in exampleapps/docs/docs/ref/dart/v0/upgrade-guide.mdx- code comment in exampleAdditional context
The rule: use "an" before acronyms pronounced with an initial vowel sound, regardless of the first letter. "MFA" starts with "em" (vowel sound), "SMS" starts with "ess" (vowel sound), "OTP" starts with "oh" (vowel sound).