Skip to content

Comments

fix: updated tab bar behavior#42875

Merged
awaseem merged 5 commits intomasterfrom
aliwaseem/fe-2574-new-filter-bar-breaks-tabshifttab-keyboard-navigation
Feb 17, 2026
Merged

fix: updated tab bar behavior#42875
awaseem merged 5 commits intomasterfrom
aliwaseem/fe-2574-new-filter-bar-breaks-tabshifttab-keyboard-navigation

Conversation

@awaseem
Copy link
Contributor

@awaseem awaseem commented Feb 16, 2026

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Fix: remove tab auto completion in favor of tab handlers

@awaseem awaseem requested a review from a team as a code owner February 16, 2026 19:49
@vercel
Copy link

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment, Open in v0 Feb 17, 2026 4:47pm
8 Skipped Deployments
Project Deployment Actions Updated (UTC)
cms Ignored Ignored Feb 17, 2026 4:47pm
studio Ignored Ignored Feb 17, 2026 4:47pm
design-system Skipped Skipped Feb 17, 2026 4:47pm
learn Skipped Skipped Feb 17, 2026 4:47pm
studio-self-hosted Skipped Skipped Feb 17, 2026 4:47pm
studio-staging Skipped Skipped Feb 17, 2026 4:47pm
ui-library Skipped Skipped Feb 17, 2026 4:47pm
zone-www-dot-com Skipped Skipped Feb 17, 2026 4:47pm

Request Review

@supabase
Copy link

supabase bot commented Feb 16, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Summary by CodeRabbit

  • Bug Fixes

    • Improved Tab and Shift+Tab keyboard navigation in the filter bar; focus now properly exits the filter input when navigating away.
  • Tests

    • Updated end-to-end tests to validate keyboard navigation behavior in the filter bar.

Walkthrough

This PR modifies keyboard navigation behavior in the FilterBar component. The changes include updates to E2E tests that verify Tab and Shift+Tab navigation exits the filter bar properly, addition of tabIndex={-1} attributes to operator and value inputs in FilterCondition to remove them from the tab order, and simplification of keyboard event handling in the navigation hook by removing Tab from a combined Enter/Tab condition. Together, these changes ensure that Tab and Shift+Tab keys move focus away from the filter bar rather than interacting with dropdown items.

Possibly related PRs


Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel vercel bot temporarily deployed to Preview – learn February 16, 2026 20:05 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

🎭 Playwright Test Results

passed  131 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  136 tests across 18 suites
duration  17 minutes, 41 seconds
commit  2c069fc

Flaky tests

Features › database.spec.ts › Database › Schema Visualizer › actions works as expected

Skipped tests

Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@blacksmith-sh

This comment has been minimized.

Copy link
Contributor

@kemaldotearth kemaldotearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have been plus one'd.

@awaseem awaseem enabled auto-merge (squash) February 17, 2026 16:00
@awaseem awaseem merged commit c558c5d into master Feb 17, 2026
25 checks passed
@awaseem awaseem deleted the aliwaseem/fe-2574-new-filter-bar-breaks-tabshifttab-keyboard-navigation branch February 17, 2026 17:05
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Braintrust eval report

Assistant (master-1771348409)

Score Average Improvements Regressions
Completeness 97.2% (+0pp) 1 🟢 1 🔴
Conciseness 0% (+0pp) - -
Goal Completion 94.4% (-1pp) 1 🟢 2 🔴
Tool Usage 100% (+3pp) 1 🟢 -
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 100% (+0pp) - -
Correctness 91.7% (+4pp) 1 🟢 -
Docs Faithfulness 63.9% (+6pp) 2 🟢 1 🔴
URL Validity 93.9% (-6pp) - 1 🔴
Time_to_first_token 0.2tok (-0.01tok) 5 🟢 7 🔴
Llm_calls 8.25 (+0.11) 3 🟢 3 🔴
Tool_calls 3.03 (+0.14) 3 🟢 3 🔴
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 94798.22tok (-2405.5tok) 5 🟢 7 🔴
Prompt_cached_tokens 45646.22tok (+1052.44tok) 6 🟢 5 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 5892.22tok (+709.67tok) 2 🟢 10 🔴
Completion_reasoning_tokens 4348.44tok (+597.33tok) 2 🟢 10 🔴
Completion_accepted_prediction_tokens 0tok (+0tok) - -
Completion_rejected_prediction_tokens 0tok (+0tok) - -
Completion_audio_tokens 0tok (+0tok) - -
Total_tokens 100690.44tok (-1695.83tok) 4 🟢 8 🔴
Estimated_cost 0.03$ (+0$) 6 🟢 6 🔴
Duration 38.39s (+4.64s) 3 🟢 9 🔴
Llm_duration 75.45s (+9.41s) 3 🟢 9 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants