Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
github-actions
bot
added
the
documentation
Contributor
🎭 Playwright Test Results
Details
Flaky testsFeatures › table-editor.spec.ts › table editor › add enums and show enums on table Skipped testsFeatures › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected |
charislam
approved these changes
Dec 5, 2025
jordienr
changed the title
Contributor
WalkthroughThis PR adds support for Axiom and S3 log drain destinations, including form schema updates, feature flag gating, icon additions, and documentation. The changes extend the log drain system with new destination types and their associated UI components. Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@apps/studio/components/interfaces/LogDrains/LogDrainDestinationSheetForm.tsx`:
- Around line 110-114: The Axiom API token is currently rendered as plain text;
update the LogDrainDestinationSheetForm to treat api_token as sensitive by
switching the form input for api_token to a password-style input
(type="password" or an Input component's secret/password prop) wherever it's
rendered for the 'axiom' destination (schema branch where type is
z.literal('axiom') and fields api_token), including the other occurrences
referenced (the other api_token input instances in the same component), and
ensure any show/hide toggle behavior preserves accessibility and validation tied
to the existing zod schema and form handlers (e.g., the form field name
'api_token' and validation messages remain unchanged).
🧹 Nitpick comments (1)
apps/docs/content/guides/telemetry/log-drains.mdx (1)
214-227: Optional: tighten wording for Axiom ingestion behavior.
The current phrasing is a bit awkward; consider clarifying the dataset and timestamp formatting in one sentence.💡 Suggested wording tweak
-Logs sent to a specified Axiom's dataset as JSON of a raw log event, -with timestamp modified to be parsed by ingestion endpoint. +Logs are sent to the specified Axiom dataset as JSON, with the timestamp formatted for the ingestion endpoint.
apps/studio/components/interfaces/LogDrains/LogDrainDestinationSheetForm.tsx
Show resolved
Hide resolved
Contributor
Braintrust eval report
|
awaseem
pushed a commit
that referenced
this pull request
Feb 3, 2026
- finished the axiom log drain started in #40209 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **New Features** * Added Axiom as a new log drain destination for telemetry data collection * Added Amazon S3 as a new log drain destination for log storage * Extended log drain configuration form with fields for S3 bucket credentials and Axiom API details * Added documentation for setting up Axiom log drain integration * **Documentation** * Added Axiom log drain setup guides with dataset creation and configuration steps <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Documentation