Skip to content

Chore: Replaced any with interface CSSProperties #29650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

0xkar4n
Copy link
Contributor

@0xkar4n 0xkar4n commented Oct 2, 2024

This PR is to update the any with interface CSSProperties where CSS is accepted as a prop which is mentioned in issue #29576
Fixes #29576

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Chore

What is the current behavior?

image

What is the new behavior?

image

@0xkar4n 0xkar4n requested a review from a team as a code owner October 2, 2024 16:56
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:40pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:40pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:40pm
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:40pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:40pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 2:40pm

Copy link

vercel bot commented Oct 2, 2024

@0xkar4n is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@JoyShaheb
Copy link

@0xkar4n The purpose is to search, find and replace all instances of the same issue. Not just the file I pointed out, there's more.

@fsansalvadore
Copy link
Contributor

@JoyShaheb actually as far as the specific issue #29576, this is actually the correct fix.
Only the style type needs to be of CSSProperties type, not all "any".

Thanks anyway for the joining the discussion!

Copy link
Contributor

@fsansalvadore fsansalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xkar4n 👍

@fsansalvadore fsansalvadore merged commit 784a3ac into supabase:master Oct 18, 2024
12 checks passed
encima pushed a commit that referenced this pull request Nov 19, 2024
Chore: Replaced any with interface CSSProperties where css is used as a props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace type any with interface CSSProperties
3 participants