Skip to content

fix(storage): analytics bucket prop #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(storage): analytics bucket prop #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/storage-js/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface ListBucketOptions {
*/
export interface AnalyticBucket {
/** Unique identifier for the bucket */
id: string
name: string
/** Bucket type - always 'ANALYTICS' for analytics buckets */
type: 'ANALYTICS'
/** Storage format used (e.g., 'iceberg') */
Expand Down
8 changes: 4 additions & 4 deletions packages/core/storage-js/src/packages/StorageAnalyticsApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { DEFAULT_HEADERS } from '../lib/constants'
import { isStorageError, StorageError } from '../lib/errors'
import { Fetch, get, post, remove } from '../lib/fetch'
import { resolveFetch } from '../lib/helpers'
import { AnalyticBucket, Bucket } from '../lib/types'
import { AnalyticBucket } from '../lib/types'

/**
* API class for managing Analytics Buckets using Iceberg tables
Expand Down Expand Up @@ -154,7 +154,7 @@ export default class StorageAnalyticsApi {
* A bucket can't be deleted with existing objects inside it
* You must first empty the bucket before deletion
*
* @param bucketId The unique identifier of the bucket you would like to delete
* @param bucketName The unique identifier of the bucket you would like to delete
* @returns Promise with success message or error
*
* @example
Expand All @@ -167,7 +167,7 @@ export default class StorageAnalyticsApi {
* }
* ```
*/
async deleteBucket(bucketId: string): Promise<
async deleteBucket(bucketName: string): Promise<
| {
data: { message: string }
error: null
Expand All @@ -180,7 +180,7 @@ export default class StorageAnalyticsApi {
try {
const data = await remove(
this.fetch,
`${this.url}/bucket/${bucketId}`,
`${this.url}/bucket/${bucketName}`,
{},
{ headers: this.headers }
)
Expand Down
Loading