fix(auth): add automatic browser redirect to signInWithSSO #1849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1848 by adding automatic browser redirect behavior to
signInWithSSO, making it consistent withsignInWithOAuth.Problem
When using
signInWithSSO, theredirectTooption was being correctly sent to the backend but ignored on the client side. UnlikesignInWithOAuth, which automatically redirects users to the provider's authorization page in browser environments,signInWithSSOonly returned the URL without performing the redirect.This inconsistency meant that:
redirectToparameter appeared to be ignoredChanges
Added automatic browser redirect logic to
signInWithSSOmethod (GoTrueClient.ts:1338-1341)skipBrowserRedirectis not explicitly set totruesignInWithOAuthand other OAuth methodsAdded
skipBrowserRedirectoption toSignInWithSSOtype (lib/types.ts:789-794, 806-811)Added test for the new option (
GoTrueClient.test.ts:3103-3120)skipBrowserRedirectoption is properly accepted