fix: prevent async calls in _listenForAuthEvents #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14973934667Details
💛 - Coveralls |
grdsdev
approved these changes
May 12, 2025
filipecabaco
added a commit
that referenced
this pull request
May 20, 2025
grdsdev
added a commit
that referenced
this pull request
May 20, 2025
* fix: Bump up realtime; add integration tests (#1395) * fix: bump up realtime-js (#1409) * fix: bump up realtime-js; await on token change (#1411) * fix: prevent async calls in _listenForAuthEvents (#1412) * fix: bump up realtime-js (#1413) * bump up realtime-js (#1419) * resolve conflict --------- Co-authored-by: Guilherme Souza <guilherme@supabase.io> Co-authored-by: Guilherme Souza <ogrsouza@gmail.com>
|
@filipecabaco I'd presume this eliminates the need for the hack to avoid deadlocks as mentioned in the docs, right? |
|
can you be more specific? |
|
@filipecabaco The docs (here) mention that awaiting async supabase functions inside the callback can cause a deadlock, and recommends dispatching it after the callback ends, as a hack. Does this PR fix that? |
|
That still needs to be avoided as this only fixed in this specific scenario and not fully as this flow really should not be async |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
prevent async calls in _listenForAuthEvents ( https://supabase.com/docs/reference/javascript/auth-onauthstatechange )