Problems with stricter typing introduced in v2.47.11

[maximilian-hammerl]

Bug report

Describe the bug

We have a lot of utility functions such as (simplified):

export async function deleteSomeData<
  Column extends string & keyof Tables<'some_data'>,
  Value extends Tables<'some_data'>[Column],
>(
  column: Column,
  value: Value,
): Promise<void> {
  const { error } = await supabase
    .from('some_data')
    .delete()
    .eq(column, value)

  if (error) {
    throw new Error(`Failed to delete some data: ${error.message}`)
  }
}

as well as more generic versions such as:

type PublicSchema = Database[Extract<keyof Database, 'public'>]
type PublicTables = PublicSchema['Tables']

export async function deleteEntity<
  TableName extends string & keyof PublicTables,
  Column extends string & keyof PublicTables[TableName]['Row'],
  Value extends PublicTables[TableName]['Row'][Column],
>(
  table: TableName,
  column: Column,
  value: Value,
): Promise<void> {
  const { error } = await supabaseAdmin
    .from(table)
    .delete()
    .eq(column, value)

  if (error) {
    throw new Error(`Failed to delete entity: ${error.message}`)
  }
}

which worked fine before 2.47.11, but with the stricter typing we get this error:

S2345 [ERROR]: Argument of type 'Value' is not assignable to parameter of type 'ResolveFilterValue<{ Tables: { ...'.
  Type '{ ...' is not assignable to type 'ResolveFilterValue<{ Tables: { ...'.
    Type '{ ...' is not assignable to type 'ResolveFilterValue<{ Tables: { ...'.
      Type '{ ...' is not assignable to type 'ResolveFilterValue<{ Tables: { ...'.
    .eq(column, value)

The error message is not helpful with debugging this problem and, so far, we were not able to fix this ourselves.

System information

• Version of supabase-js: 2.47.11 and 2.47.12

[maximilian-hammerl]

We were able to fix this by using the new ResolveFilterValue and ResolveFilterRelationshipValue types. (We had to copy them, as they are not exported.)

type ResolveFilterValue<
  Schema extends PublicSchema,
  Row extends Record<string, unknown>,
  ColumnName extends string,
> = ColumnName extends `${infer RelationshipTable}.${infer Remainder}`
  ? Remainder extends `${infer _}.${infer _}` ? ResolveFilterValue<Schema, Row, Remainder>
  : ResolveFilterRelationshipValue<Schema, RelationshipTable, Remainder>
  : ColumnName extends keyof Row ? Row[ColumnName]
  : never
type ResolveFilterRelationshipValue<
  Schema extends PublicSchema,
  RelationshipTable extends string,
  RelationshipColumn extends string,
> = Schema['Tables'] & Schema['Views'] extends infer TablesAndViews
  ? RelationshipTable extends keyof TablesAndViews
    ? 'Row' extends keyof TablesAndViews[RelationshipTable]
      ? RelationshipColumn extends keyof TablesAndViews[RelationshipTable]['Row']
        ? TablesAndViews[RelationshipTable]['Row'][RelationshipColumn]
      : unknown
    : unknown
  : unknown
  : never

export async function deleteEntity<
  TableName extends string & keyof PublicTables,
  Column extends string & keyof PublicTables[TableName]['Row'],
  Value extends ResolveFilterValue<PublicSchema, PublicTables[TableName]['Row'], Column> extends
    never ? NonNullable<unknown>
    : NonNullable<ResolveFilterValue<PublicSchema, PublicTables[TableName]['Row'], Column>>,
>(
  table: TableName,
  column: Column,
  value: Value,
): Promise<void> {
  const { error } = await supabaseAdmin
    .from(table)
    .delete()
    .eq(column, value)

  if (error) {
    throw new Error(`Failed to delete entity: ${error.message}`)
  }
}

[thisislvca]

It'd be useful to have them exported too I guess. Having lots of issues with it too.

[maximilian-hammerl]

@thisislvca, I've created a PR for both types: supabase/postgrest-js#596

If the PR is merged, I will also create a PR for supabase-js to also export these types.

[thisislvca]

Ah thanks a lot man 🔥