Repository navigation
fix: evaluate postgres_changes filters against the raw wal2json values - #2362
Open
mandar1045 wants to merge 1 commit into
Open
mandar1045 wants to merge 1 commit into
mandar1045 wants to merge 1 commit into
Conversation
apply_rls passed filters the jsonb-cast column values, so check_equality_op
got ["a"] for an array instead of {a} and raised, dropping the whole
list_changes batch for every subscriber.
Build the filter columns from the wal2json values, which are already in
Postgres literal form. The cast columns are still used for the payload.
Fixes supabase#2361
mandar1045
force-pushed
the
fix/filter-on-raw-wal-values
branch
2 times, most recently
from
October 7, 2026 12:25
028ebab to
5414596
Compare
Contributor
Author
|
The only failing job (multigres partition 3) is the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2361
apply_rlswas passing filters the jsonb-cast column values, socheck_equality_opgot["a"]for an array instead of{a}and raised, dropping the whole batch for everyone.This makes
apply_rlsbuild the filter columns straight from the wal2json values, which are already in Postgres literal form. The castcolumnsare still used for the payload, so the output doesn't change.is_visible_through_filtersandcheck_equality_opare untouched.apply_rlswith that change onlytenant_schemaand the pg15/pg17 dumpspostgres_changes_filters_test.exsWalrus suite passes on 15 and 17, from both the dumps and the migrations.