Skip to content

fix: specify that only private channels are allowed when replaying #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

fix: specify that only private channels are allowed when replaying #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/realtime_web/channels/realtime_channel.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ defmodule RealtimeWeb.RealtimeChannel do
{:error, :invalid_replay_params} ->
log_error(socket, "UnableToReplayMessages", "Replay params are not valid")

{:error, :invalid_replay_channel} ->
log_error(socket, "UnableToReplayMessages", "Replay is not allowed for public channels")

{:error, error} ->
log_error(socket, "UnknownErrorOnChannel", error)
{:error, %{reason: "Unknown Error on Channel"}}
Expand Down Expand Up @@ -790,7 +793,7 @@ defmodule RealtimeWeb.RealtimeChannel do
end

defp maybe_replay_messages(%{"broadcast" => %{"replay" => _}}, _sub_topic, _db_conn, false = _private?) do
{:error, :invalid_replay_params}
{:error, :invalid_replay_channel}
end

defp maybe_replay_messages(%{"broadcast" => %{"replay" => replay_params}}, sub_topic, db_conn, true = _private?)
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule Realtime.MixProject do
def project do
[
app: :realtime,
version: "2.51.3",
version: "2.51.4",
elixir: "~> 1.17.3",
elixirc_paths: elixirc_paths(Mix.env()),
start_permanent: Mix.env() == :prod,
Expand Down
2 changes: 1 addition & 1 deletion test/realtime_web/channels/realtime_channel_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ defmodule RealtimeWeb.RealtimeChannelTest do

assert {
:error,
%{reason: "UnableToReplayMessages: Replay params are not valid"}
%{reason: "UnableToReplayMessages: Replay is not allowed for public channels"}
} = subscribe_and_join(socket, "realtime:test", %{"config" => config})

refute_receive _any
Expand Down
Loading