fix: improve deployment to be more platform agnostic #1506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
currently we have fly and aws very hardcoded so we need to reduce that by changing the way we setup realtime to be less locked to this ecosystems the first we are focusing on read replicas which is very hard coded to our infrastructure.
filipecabaco
force-pushed
the
feat/remove-platform-settings
branch
from
fc11195 to
9231dd8
Compare
edgurgel
reviewed
Aug 27, 2025
| connect_partition_slots = Env.get_integer("CONNECT_PARTITION_SLOTS", System.schedulers_online() * 2) | ||
| metrics_cleaner_schedule_timer_in_ms = Env.get_integer("METRICS_CLEANER_SCHEDULE_TIMER_IN_MS", :timer.minutes(30)) | ||
| metrics_rpc_timeout_in_ms = Env.get_integer("METRICS_RPC_TIMEOUT_IN_MS", :timer.seconds(15)) | ||
| rebalance_check_interval_in_ms = Env.get_integer("REBALANCE_CHECK_INTERVAL_IN_MS", :timer.seconds(10)) |
There was a problem hiding this comment.
this one should be :timer.minutes(10)
edgurgel
reviewed
Aug 27, 2025
| connect_partition_slots = Env.get_integer("CONNECT_PARTITION_SLOTS", System.schedulers_online() * 2) | ||
| metrics_cleaner_schedule_timer_in_ms = Env.get_integer("METRICS_CLEANER_SCHEDULE_TIMER_IN_MS", :timer.minutes(30)) | ||
| metrics_rpc_timeout_in_ms = Env.get_integer("METRICS_RPC_TIMEOUT_IN_MS", :timer.seconds(15)) | ||
| rebalance_check_interval_in_ms = Env.get_integer("REBALANCE_CHECK_INTERVAL_IN_MS", :timer.seconds(10)) |
There was a problem hiding this comment.
Suggested change
| rebalance_check_interval_in_ms = Env.get_integer("REBALANCE_CHECK_INTERVAL_IN_MS", :timer.seconds(10)) | |
| rebalance_check_interval_in_ms = Env.get_integer("REBALANCE_CHECK_INTERVAL_IN_MS", :timer.minutes(10)) |
edgurgel
reviewed
Aug 27, 2025
| # 4 hours by default | ||
| janitor_schedule_timer = System.get_env("JANITOR_SCHEDULE_TIMER_IN_MS", "14400000") |> String.to_integer() | ||
| # defaults to 10 minutes | ||
| Env.get_integer("DISCONNECT_SOCKET_ON_NO_CHANNELS_INTERVAL_IN_MS", :timer.seconds(30)) |
There was a problem hiding this comment.
I don't think this disconnect_socket_on_no_channels_interval_in_ms is being used at all. Should we just remove it?
edgurgel
reviewed
Aug 27, 2025
| config :realtime, run_janitor: false | ||
| else | ||
| if config_env() != :test && run_janitor? do | ||
| config :realtime, |
There was a problem hiding this comment.
Where we are setting run_janitor: false when run_janitor? is false?
edgurgel
reviewed
Aug 27, 2025
| url: [host: "#{app_name}.supabase.co", port: 443], | ||
| http: [ | ||
| compress: true, | ||
| port: Env.get_integer("PORT", 443), |
edgurgel
reviewed
Aug 27, 2025
|
|
||
| config :realtime, RealtimeWeb.Endpoint, | ||
| server: true, | ||
| url: [host: "#{app_name}.supabase.co", port: 443], |
edgurgel
reviewed
Aug 27, 2025
| export DB_HOST_REPLICA_TARGET_REGIONS_us-east-1='us-east-1,us-east-2,us-east-3' | ||
| ``` | ||
|
|
||
| This will inform realtime that nodes connected to the `us-east-1` region will be able to connect to the replica database for the `us-east-1` region. If the region is not specified, the we will set the main repository as the default. |
There was a problem hiding this comment.
how us-east-1 and us-east-2 etc are used in this example
If the region is not specified, the we will set the main repository as the default.
*then ?
edgurgel
reviewed
Aug 27, 2025
| region_mapping(platform, tenant_region) | ||
| end | ||
|
|
||
| defp region_mapping(:aws, tenant_region) do |
There was a problem hiding this comment.
Should this be configured through the ENV vars as well? (Not in this PR but in the future?)
There was a problem hiding this comment.
yes it will be just wanted to make it in a different PR but it will be similar to the existing one 👀
edgurgel
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
currently we have fly and aws very hardcoded so we need to reduce that by changing the way we setup realtime to be less locked to this ecosystems
the first we are focusing on read replicas which is very hard coded to our infrastructure.
for read replicas you can set:
which will setup the
us-east-1read replica and inform realtime that the regionsus-east-1,us-east-2,us-east-3should use this read replica. if not, they will use the default repo.