Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@mandarini
Copy link
Contributor

@mandarini mandarini commented Sep 5, 2025

What kind of change does this PR introduce?

Bug fix - Eliminates Next.js Edge Runtime warnings

What is the current behavior?

Direct access to process.versions in websocket-factory.ts causes Next.js static analysis to flag the code as incompatible with Edge Runtime, even though the code is properly guarded and won't execute in Edge Runtime.

Fixes #523

What is the new behavior?

Uses dynamic property access (process['versions']) to avoid static analysis warnings while maintaining the same runtime behavior. The code still correctly detects Node.js versions and provides appropriate WebSocket implementations.

Additional context

@mandarini mandarini self-assigned this Sep 5, 2025
@mandarini mandarini marked this pull request as ready for review September 5, 2025 08:17
@supabase supabase deleted a comment from github-actions bot Sep 5, 2025
@mandarini mandarini added the trigger: preview Triggers a preview release for this PR. label Sep 5, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 5, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@supabase/realtime-js@533

commit: fe3ca3f

@supabase supabase deleted a comment from github-actions bot Sep 5, 2025
@mandarini mandarini merged commit 1fb25b9 into supabase:master Sep 5, 2025
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

trigger: preview Triggers a preview release for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process.version Node.js API not supported in Edge Runtime

2 participants