This repository was archived by the owner on Oct 9, 2025. It is now read-only.
add: Worker for Healthcheck #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecabaco
force-pushed
the
feat/add-worker-logic
branch
from
7cf5c0d to
0fd9786
Compare
Added capacity to use Worker for Healthchecks. We also allow users to override the worker URL so they are able to modify it as they see fit
filipecabaco
force-pushed
the
feat/add-worker-logic
branch
from
1a50028 to
27373cc
Compare
chasers
approved these changes
Aug 30, 2024
chasers
reviewed
Aug 30, 2024
grdsdev
reviewed
Aug 30, 2024
Comment on lines
+127
to
+128
| * @param options.worker Use Web Worker to set a side flow. Defaults to false. | ||
| * @param options.workerUrl The URL of the worker script. Defaults to https://realtime.supabase.com/worker.js that includes a heartbeat event call to keep the connection alive. |
There was a problem hiding this comment.
What if we group this 2 params into only one of type worker: string | bool and default it to false?
- If worker is a bool, and false, don't use worker
- If worker is bool and true, use default worker url
- if worker is string, use it as the url, this also means you wan't to use worker flow
There was a problem hiding this comment.
unsure... personally I kind of like it making it explicit and have options for all has that means "one thing, one behaviour change"
this feels that there are 3 possible behaviours attached to a single argument that would need extra doc reading vs intellisense for example
w3b6x9
reviewed
Aug 30, 2024
w3b6x9
reviewed
Aug 30, 2024
w3b6x9
reviewed
Aug 30, 2024
w3b6x9
reviewed
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added capacity to use Worker for Healthchecks. We also allow users to override the worker URL so they are able to modify it as they see fit