Skip to content

feat: detect one-to-one relationships #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

soedirgo
Copy link
Member

@soedirgo soedirgo commented Oct 31, 2023

What kind of change does this PR introduce?

feature

What is the current behavior?

Doesn't detect one-to-one relationships - foreign table would be typed as T[]

What is the new behavior?

Foreign table on a one-to-one relationship would be typed as T | null

@soedirgo soedirgo force-pushed the feat/detect-one-to-one-rels branch from a3cf5ca to 32932bd Compare November 22, 2023 08:45
@soedirgo soedirgo marked this pull request as ready for review November 22, 2023 08:46
Copy link
Contributor

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from chore/update-generated-types to master November 22, 2023 08:58
@soedirgo soedirgo merged commit f91aa29 into master Nov 22, 2023
@soedirgo soedirgo deleted the feat/detect-one-to-one-rels branch November 22, 2023 08:59
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants