Add tests for ansible and system manager modules by jfroche · Pull Request #1746 · supabase/postgres

jfroche · 2025-08-11T12:58:09Z

We are slowly moving ansible code to nix system manager modules.
To speed up the migration, we want to test the ansible code without building the whole AMI and have a fast feedback loop.
We also want to quickly test our changes on system manager modules.

The tests are running docker images with ubuntu using testinfra.

hunleyd · 2025-09-03T15:43:43Z

ansible/tasks/setup-nix.yml

+- name: Check if nix is installed
+  ansible.builtin.command: which nix
+  register: nix_installed
+  failed_when: nix_installed.rc != 0
+  ignore_errors: true
+
+- name: Install nix
+  ansible.builtin.shell: curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix | sh -s -- install --no-confirm --extra-conf 'substituters = https://cache.nixos.org https://nix-postgres-artifacts.s3.amazonaws.com' --extra-conf 'trusted-public-keys = nix-postgres-artifacts:dGZlQOvKcNEjvT7QEAJbcV6b6uk7VF/hWMjhYleiaLI=% cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY='
+  when: nix_installed.rc != 0
+  become: true


instead of ignore_errors, why not use a block/rescue

Suggested change

- name: Check if nix is installed

ansible.builtin.command: which nix

register: nix_installed

failed_when: nix_installed.rc != 0

ignore_errors: true

- name: Install nix

ansible.builtin.shell: curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix | sh -s -- install --no-confirm --extra-conf 'substituters = https://cache.nixos.org https://nix-postgres-artifacts.s3.amazonaws.com' --extra-conf 'trusted-public-keys = nix-postgres-artifacts:dGZlQOvKcNEjvT7QEAJbcV6b6uk7VF/hWMjhYleiaLI=% cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY='

when: nix_installed.rc != 0

become: true

- name: Install nix if needed

block:

- name: Check if nix is installed

ansible.builtin.command: which nix

register: nix_installed

failed_when: nix_installed.rc != 0

rescue:

- name: Install nix

ansible.builtin.shell: curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix | sh -s -- install --no-confirm --extra-conf 'substituters = https://cache.nixos.org https://nix-postgres-artifacts.s3.amazonaws.com' --extra-conf 'trusted-public-keys = nix-postgres-artifacts:dGZlQOvKcNEjvT7QEAJbcV6b6uk7VF/hWMjhYleiaLI=% cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY='

become: true

Move pgrouting.nix to pgrouting/default.nix and groonga package to pgroonga/groonga.nix. Update imports and fix relative paths for versions.json and patch files.

Replace inline bash script generation with writeShellScriptBin for rustc wrapper that filters empty postmaster_stub.rs arguments. Apply wrapper only for pgrx < 0.12 since issue was fixed upstream in pgrx#1435 and pgrx#1441.

Move nixpkgs-oldstable import to a let binding to avoid importing it three times...

Remove supabase-groonga from global flake packages and import it locally in pgroonga extension instead. Other components access groonga via pgroonga.passthru.groonga since groonga is only used by pgroonga.

The supabase-groonga package was moved to pgroonga extension in commit 1f0ed1f, but Ansible was still trying to install it separately causing build failures.

This reverts commit 55474686405394826ad07a032cbcf0e36a924554.

This reverts commit cfa9bcb92219f391469ae743f95c8856b0a99561.

Remove references to darwin.apple_sdk.frameworks.{IOKit,CoreFoundation} which have been deprecated in nixpkgs. Disable CGO to avoid Darwin framework dependencies entirely.

This complements the existing AMI tests in testinfra by providing a faster feedback loops for Ansible development without requiring a full VM. Also as it is based on Docker, it can be run locally (e.g. macOS) or in CI. Note that this approach is not intended to replace the AMI tests, but rather to provide a more efficient way to test Ansible tasks during development. Docker is used outside of the Nix sandbox for the moment. You can run the tests using `nix run -L .\#ansible-test`

coderabbitai · 2025-12-29T17:22:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/ansible-testing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

And use docker to run tests

Move ubuntu docker image to its own package. Create one test for all system modules.

…b actions workflows

jfroche · 2026-01-29T22:59:19Z

Superseded by #1882 and #2010

jfroche changed the base branch from develop to update-nixpkgs August 11, 2025 12:58

jfroche changed the base branch from update-nixpkgs to develop August 11, 2025 12:59

jfroche force-pushed the feat/ansible-testing branch from 551892e to e5e1b82 Compare August 11, 2025 16:43

jfroche changed the base branch from develop to update-nixpkgs August 11, 2025 16:44

samrose force-pushed the update-nixpkgs branch from 337be4e to dab9e52 Compare August 18, 2025 15:16

jfroche force-pushed the feat/ansible-testing branch 2 times, most recently from 8549d92 to c2bd94d Compare August 19, 2025 18:00

jfroche marked this pull request as ready for review August 29, 2025 12:11

jfroche requested review from a team as code owners August 29, 2025 12:11

samrose force-pushed the update-nixpkgs branch from 569b4cc to c061085 Compare September 2, 2025 13:27

samrose requested a review from a team as a code owner September 2, 2025 13:27

samrose force-pushed the update-nixpkgs branch from c061085 to 07fb5e2 Compare September 2, 2025 13:28

hunleyd requested changes Sep 3, 2025

View reviewed changes

samrose force-pushed the update-nixpkgs branch 2 times, most recently from 6b51806 to a33cf5d Compare September 10, 2025 17:58

jfroche force-pushed the feat/ansible-testing branch 2 times, most recently from b3b0a55 to fc77a26 Compare September 12, 2025 11:57

samrose force-pushed the update-nixpkgs branch from 684c4b7 to 21a8f63 Compare September 17, 2025 20:43

samrose force-pushed the update-nixpkgs branch 2 times, most recently from 37962e0 to 52722b1 Compare November 18, 2025 15:46

yvan-sraka force-pushed the update-nixpkgs branch 5 times, most recently from dc596ec to 758c52d Compare November 25, 2025 17:46

jfroche force-pushed the update-nixpkgs branch 2 times, most recently from 778aa93 to 7f7fad9 Compare November 26, 2025 00:28

yvan-sraka force-pushed the update-nixpkgs branch 2 times, most recently from 5080bbe to 1504f7b Compare December 1, 2025 10:10

yvan-sraka and others added 11 commits December 17, 2025 14:36

fix(exts): remove remaining duplicated files

e0a9e5e

Move pgrouting.nix to pgrouting/default.nix and groonga package to pgroonga/groonga.nix. Update imports and fix relative paths for versions.json and patch files.

refactor(pgrx): conditionally apply rustc wrapper when < 0.12

8f4a99a

Replace inline bash script generation with writeShellScriptBin for rustc wrapper that filters empty postmaster_stub.rs arguments. Apply wrapper only for pgrx < 0.12 since issue was fixed upstream in pgrx#1435 and pgrx#1441.

refactor(nixpkgs): use let binding for oldstable instead of overlay

7597e3b

Move nixpkgs-oldstable import to a let binding to avoid importing it three times...

refactor(groonga): move groonga package to pgroonga extension

2ac85c8

Remove supabase-groonga from global flake packages and import it locally in pgroonga extension instead. Other components access groonga via pgroonga.passthru.groonga since groonga is only used by pgroonga.

fix(ansible): remove supabase-groonga from package install list

3e9d6b5

The supabase-groonga package was moved to pgroonga extension in commit 1f0ed1f, but Ansible was still trying to install it separately causing build failures.

Revert "fix(ansible): remove supabase-groonga from package install list"

962db9e

This reverts commit 55474686405394826ad07a032cbcf0e36a924554.

Revert "refactor(groonga): move groonga package to pgroonga extension"

1f5ab20

This reverts commit cfa9bcb92219f391469ae743f95c8856b0a99561.

fix(darwin): remove deprecated apple_sdk frameworks from supascan

3e729f7

Remove references to darwin.apple_sdk.frameworks.{IOKit,CoreFoundation} which have been deprecated in nixpkgs. Disable CGO to avoid Darwin framework dependencies entirely.

chore: bump version suffix to test

747a547

chore: bump to retest

2b48244

chore: suffix to test

4e32d5b

samrose force-pushed the update-nixpkgs branch from 771718f to 4e32d5b Compare December 17, 2025 19:36

samrose and others added 2 commits December 17, 2025 14:38

chore: bump to test

6c2d201

jfroche force-pushed the feat/ansible-testing branch from f478f94 to 8bf8a53 Compare December 29, 2025 17:22

jfroche and others added 7 commits December 29, 2025 18:29

feat: deploy nginx using system manager

2afe94e

And use docker to run tests

chore: simplify system manager tests

83f8ad3

Move ubuntu docker image to its own package. Create one test for all system modules.

chore: formatting

9144fcc

Test system manager deployment triggered by Ansible

9556ef7

Create default system manager configuration

a6de462

ci: make sure we cache system manager and its test dependencies

f892bb3

chores: add nix run .#ansible-test and .#check-system-module to githu…

0b687d4

…b actions workflows

jfroche force-pushed the feat/ansible-testing branch from 8bf8a53 to 0b687d4 Compare December 29, 2025 17:33

jfroche force-pushed the update-nixpkgs branch from acf3ba4 to 42b0c29 Compare January 5, 2026 17:25

samrose force-pushed the update-nixpkgs branch from fa26b67 to 0131d17 Compare January 15, 2026 22:41

Base automatically changed from update-nixpkgs to develop January 16, 2026 00:23

samrose approved these changes Jan 27, 2026

View reviewed changes

jfroche closed this Jan 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add tests for ansible and system manager modules#1746

Add tests for ansible and system manager modules#1746
jfroche wants to merge 64 commits intodevelopfrom
feat/ansible-testing

jfroche commented Aug 11, 2025

Uh oh!

hunleyd Sep 3, 2025

Uh oh!

coderabbitai bot commented Dec 29, 2025

Review skipped

Uh oh!

jfroche commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jfroche commented Aug 11, 2025

Uh oh!

hunleyd Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Dec 29, 2025

Review skipped

Uh oh!

jfroche commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants