Skip to content

fix(publications): disambiguate tables' schemas #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

soedirgo
Copy link
Member

What kind of change does this PR introduce?

Bug fix.

What is the current behavior?

/publications's tables only have names, so we can't differentiate tables from different schemas.

What is the new behavior?

Make tables a JSON object as per #97. (Breaking change)

Additional context

Closes #97.

@soedirgo soedirgo requested a review from kiwicopple February 27, 2021 04:25
@kiwicopple
Copy link
Member

🔥

@kiwicopple kiwicopple merged commit 64f3eb2 into develop Feb 27, 2021
soedirgo added a commit that referenced this pull request Feb 28, 2021
Probably better to specify `tables` using OIDs when creating
publications, but this'll do for now.
@soedirgo soedirgo mentioned this pull request Feb 28, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.15.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@soedirgo soedirgo deleted the fix/publication-tables branch June 21, 2021 06:48
avallete pushed a commit that referenced this pull request May 13, 2025
fix(publications): disambiguate tables' schemas
avallete pushed a commit that referenced this pull request May 13, 2025
Probably better to specify `tables` using OIDs when creating
publications, but this'll do for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting Publications with multiple schemas returns duplicate table names
2 participants