fix: Close both apps to allow for process restart #885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the main
app
is closed, or any node.js termination signal is sent (which is hijacked bycloseWithGrace
https://github.com/mcollina/close-with-grace?tab=readme-ov-file#api), anadminApp
instance will keep it hostage and won't allow ec2 to restart everything correctly.This can be tested by updating
/health
endpoint to callapp.close()
and observing that process is still running due toadminApp
server being bound.This will hopefully kill server instantly and won't let other requests come in to this instance as observed in our ec2 logs now.
Sidenote: why do we expose prometheus metrics on a separate port/app and not just
/metrics
endpoint within same app instead? @soedirgo