Skip to content

fix(typegen): use base/composite/enum type for fn columns #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 9, 2023
Merged

fix(typegen): use base/composite/enum type for fn columns #624

merged 7 commits into from
Nov 9, 2023

Conversation

gulfaraz
Copy link
Contributor

What kind of change does this PR introduce?

This PR changes gen:types:typescript to generate types for function columns instead of unknown.

What is the current behavior?

The current output is,

// todos
Row: {
    details: string | null
    id: number
    "user-id": number
    blurb: string | null
    blurb_varchar: unknown | null
    details_is_long: unknown | null
    details_length: unknown | null
}

What is the new behavior?

// todos
Row: {
    details: string | null
    id: number
    "user-id": number
    blurb: string | null
    blurb_varchar: string | null
    details_is_long: boolean | null
    details_length: number | null
}

@gulfaraz gulfaraz requested review from a team as code owners October 23, 2023 19:59
@gulfaraz gulfaraz changed the title fix: use base/composite/enum type for fn columns fix(typegen): use base/composite/enum type for fn columns Oct 27, 2023
@soedirgo
Copy link
Member

soedirgo commented Nov 9, 2023

Thanks for the PR @gulfaraz!

@soedirgo soedirgo enabled auto-merge November 9, 2023 06:17
@soedirgo soedirgo merged commit b40aec2 into supabase:master Nov 9, 2023
@gulfaraz gulfaraz deleted the fix.fn-return-type branch November 21, 2023 18:41
avallete pushed a commit that referenced this pull request May 13, 2025
This reverts commit 92df521.

The issue the above commit is meant to fix is probably fixed by #624.
avallete pushed a commit that referenced this pull request May 13, 2025
fix(typegen): use base/composite/enum type for fn columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants