Skip to content

[WIP] feat(/functions): add remaining functions routes #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2021

Conversation

i-pip
Copy link
Contributor

@i-pip i-pip commented Jun 17, 2021

What kind of change does this PR introduce?

functions list action is already implemented, adding the remaining actions (get, post, patch,
delete). Beginning with this test for GET on /functions/:id

What is the current behavior?

list method already implemented, missing get, post, patch & delete

Please link any relevant issues here.

#115

Additional context

Please pardon my linter's overzealous linting 🙈

functions list action is already implemented, adding the remaining actions (get, post, patch,
delete). Beginning with this test for GET on /functions/:id
@i-pip i-pip changed the title feat(/functions): add remaining functions routes [WIP] feat(/functions): add remaining functions routes Jun 17, 2021
@kiwicopple kiwicopple requested a review from soedirgo June 18, 2021 11:14
@kiwicopple
Copy link
Member

wow, nice @i-pip 🔥 cool that you implemented this after the livestream.

@soedirgo does this look OK?

Copy link
Member

@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @i-pip! (And I like the lint!) Just one small fix :)

Co-authored-by: Bobbie Soedirgo <bobbie@soedirgo.dev>
@i-pip
Copy link
Contributor Author

i-pip commented Jun 18, 2021

Thanks for the PR @i-pip! (And I like the lint!) Just one small fix :)

Thanks a ton @soedirgo! Fix applied 🕺🏾

@soedirgo soedirgo merged commit 0fa7587 into supabase:develop Jun 18, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

avallete pushed a commit that referenced this pull request May 13, 2025
* feat(/functions): add remaining functions routes

functions list action is already implemented, adding the remaining actions (get, post, patch,
delete). Beginning with this test for GET on /functions/:id

* Adds implementation for GET /functions/:id

* fix: get function by id or name instead of schema

* Update src/lib/PostgresMetaFunctions.ts

Co-authored-by: Bobbie Soedirgo <bobbie@soedirgo.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants