Support PostgreSQL 18 and use latest pgrx 0.16.1 #611
Conversation
Using `brew install icu4c` and `PKG_CONFIG_PATH=/opt/homebrew/opt/icu4c/lib/pkgconfig cargo pgrx init` since I ran this on macOS. Ran tests with `cargo pgrx test` and they are passing.
Tested locally with ``` PG_VERSION=18 docker compose -f .ci/docker-compose.yml build PG_VERSION=18 docker compose -f .ci/docker-compose.yml run test ``` And got `# All 119 tests passed.`
There was a problem hiding this comment.
Thanks for the PR. Could you please also update the version at following locations:
pg_graphql/.github/workflows/coverage.yml
Line 46 in fe057d3
pg_graphql/.github/workflows/release.yml
Line 46 in fe057d3
Consistent with the ci build.
|
@jhf a GH check is failing here: https://github.com/supabase/pg_graphql/actions/runs/18682416437/job/53347499160?pr=611#step:3:1487. Could you please take a look. |
I see the coverage hard codes pg 16 - I changed to 18, so we can see if that works. If it's ok we can go with that, if not, I can use pg 16 for coverage. |
|
pg 18 is fine for generating coverage. Latest run failed with another error: https://github.com/supabase/pg_graphql/actions/runs/18714693222/job/53371283791?pr=611 |
I fixed that, and now the tests are passing. |
2 participants
What kind of change does this PR introduce?
Upgrade pgrx to 0.16.1 that support PostgreSQL 18, and add support for PostgreSQL 18.
What is the current behavior?
Build of pg_graphql against PostgreSQL 18 fails.
What is the new behavior?
Build of pg_graphql against PostgreSQL 18 works.
Additional context
I also changed the CI to test pg 18, and to use it by default.