Skip to content

Ignore type definitions in coverage metrics #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

olirice
Copy link
Contributor

@olirice olirice commented Apr 1, 2025

What kind of change does this PR introduce?

Type definition files (.d.ts files) should not be included in coverage calculations. They are TypeScript declaration files that only contain type information and are removed during compilation to JavaScript. Including in the coverage reportartificially lowers the overall metric

@olirice olirice requested a review from grdsdev April 1, 2025 17:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14202370083

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+17.4%) to 92.222%

Totals Coverage Status
Change from base Build 12398927075: 17.4%
Covered Lines: 219
Relevant Lines: 232

💛 - Coveralls

@grdsdev grdsdev merged commit 749ff05 into main Apr 1, 2025
3 checks passed
@grdsdev grdsdev deleted the or/skip-type-def-in-coverage branch April 1, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants