Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load nested env files up to repo directory #3048

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 15, 2025

What kind of change does this PR introduce?

closes #1001

What is the new behavior?

Branching environments defaults to repo directory. In a monorepo setup, the supabase directory may be arbitrarily nested. So we find all parent .env files starting from the location of config.toml.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12789228787

Details

  • 14 of 22 (63.64%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 58.415%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 14 22 63.64%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12781919307: -0.03%
Covered Lines: 7587
Relevant Lines: 12988

💛 - Coveralls

@sweatybridge sweatybridge merged commit 678f978 into develop Jan 15, 2025
9 checks passed
@sweatybridge sweatybridge deleted the nested-env branch January 15, 2025 13:30
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document default supabase/functions/.env for supabase start
2 participants