fix: use URL-safe Base64 decoding for Firebase Scrypt password hash and salt#2283
Open
taise-hikawa wants to merge 3 commits intosupabase:masterfrom
Open
fix: use URL-safe Base64 decoding for Firebase Scrypt password hash and salt#2283taise-hikawa wants to merge 3 commits intosupabase:masterfrom
taise-hikawa wants to merge 3 commits intosupabase:masterfrom
Conversation
Contributor
|
Instead of using |
Pull Request Test Coverage Report for Build 20006493610Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Author
Author
|
@hf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Firebase Scrypt password hash and salt decoding uses base64.StdEncoding.
When users are exported from Firebase, their PasswordHash may contain URL-safe Base64 characters (
-and_). These characters cannot be decoded by base64.StdEncoding.DecodeString(), causing decoding errors.Related issue: firebase/firebase-admin-go#479
What is the new behavior?
signerKeyandsaltSeparatorcontinue to use base64.StdEncoding (as they are provided in standard Base64 format)Test updates:
/) in salt and hash results in errorsAdditional context
According to Firebase Admin SDK Issue firebase/firebase-admin-go#479, when exporting user data from Firebase, the PasswordHash is encoded in URL-safe Base64, while the signerKey provided in the Firebase Console uses standard Base64.
When importing users from Firebase Auth, the exported data contains URL-safe Base64 encoded values like:
Both passwordHash and passwordSalt contain
-characters, which are URL-safe Base64 specific and cannot be decoded with standard Base64.