Skip to content

chore: align the MFA enrollment notification defaults #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: align the MFA enrollment notification defaults #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,11 +594,11 @@ Email subject to use for email changed notification. Defaults to `Your email add

`GOTRUE_MAILER_SUBJECTS_MFA_FACTOR_ENROLLED_NOTIFICATION` - `string`

Email subject to use for MFA factor enrolled notification. Defaults to `MFA factor enrolled`.
Email subject to use for MFA factor enrolled notification. Defaults to `A new MFA factor has been enrolled`.

`GOTRUE_MAILER_SUBJECTS_MFA_FACTOR_UNENROLLED_NOTIFICATION` - `string`

Email subject to use for MFA factor unenrolled notification. Defaults to `MFA factor unenrolled`.
Email subject to use for MFA factor unenrolled notification. Defaults to `An MFA factor has been unenrolled`.

`MAILER_TEMPLATES_INVITE` - `string`

Expand Down
4 changes: 2 additions & 2 deletions example.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ GOTRUE_MAILER_SUBJECTS_EMAIL_CHANGED_NOTIFICATION="Your email address has been c
GOTRUE_MAILER_SUBJECTS_PHONE_CHANGED_NOTIFICATION="Your phone number has been changed"
GOTRUE_MAILER_SUBJECTS_IDENTITY_LINKED_NOTIFICATION="A new identity has been linked"
GOTRUE_MAILER_SUBJECTS_IDENTITY_UNLINKED_NOTIFICATION="An identity has been unlinked"
GOTRUE_MAILER_SUBJECTS_MFA_FACTOR_ENROLLED_NOTIFICATION="MFA factor enrolled"
GOTRUE_MAILER_SUBJECTS_MFA_FACTOR_UNENROLLED_NOTIFICATION="MFA factor unenrolled"
GOTRUE_MAILER_SUBJECTS_MFA_FACTOR_ENROLLED_NOTIFICATION="A new MFA factor has been enrolled"
GOTRUE_MAILER_SUBJECTS_MFA_FACTOR_UNENROLLED_NOTIFICATION="An MFA factor has been unenrolled"
GOTRUE_MAILER_SECURE_EMAIL_CHANGE_ENABLED="true"

# Custom mailer template config
Expand Down
8 changes: 4 additions & 4 deletions internal/mailer/templatemailer/templatemailer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ const defaultIdentityUnlinkedNotificationMail = `<h2>An identity has been unlink
<p>If you did not make this change, please contact support immediately.</p>
`

const defaultMFAFactorEnrolledNotificationMail = `<h2>MFA factor has been enrolled</h2>
const defaultMFAFactorEnrolledNotificationMail = `<h2>A new MFA factor has been enrolled</h2>

<p>A new factor ({{ .FactorType }}) has been enrolled for your account {{ .Email }}.</p>
<p>If you did not make this change, please contact support immediately.</p>
`

const defaultMFAFactorUnenrolledNotificationMail = `<h2>MFA factor has been unenrolled</h2>
const defaultMFAFactorUnenrolledNotificationMail = `<h2>An MFA factor has been unenrolled</h2>

<p>A factor ({{ .FactorType }}) has been unenrolled for your account {{ .Email }}.</p>
<p>If you did not make this change, please contact support immediately.</p>
Expand Down Expand Up @@ -140,8 +140,8 @@ var (
PhoneChangedNotification: "Your phone number has been changed",
IdentityLinkedNotification: "A new identity has been linked",
IdentityUnlinkedNotification: "An identity has been unlinked",
MFAFactorEnrolledNotification: "MFA factor enrolled",
MFAFactorUnenrolledNotification: "MFA factor unenrolled",
MFAFactorEnrolledNotification: "A new MFA factor has been enrolled",
MFAFactorUnenrolledNotification: "An MFA factor has been unenrolled",
}
defaultTemplateBodies = &conf.EmailContentConfiguration{
Invite: defaultInviteMail,
Expand Down