chore: add webauthn tests #1127
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enhancement + Small bug fix
Add tests for the
webauthn
factorType and its (de)serialization/merging helpers.Fix fallback naming for the credential when no friendlyname is provided and the username is null
What is the current behavior?
The
factorId
parameter was being sent in both the URL path and the request body when calling the MFA challenge endpoint, which could cause issues with the API.No tests for factorType
webauthn
What is the new behavior?
factorId
from params in the_challenge
method to only include it in the URL path, not the request bodyAdditional context
We still need to bump the /auth version in the
dockor-compose.yml
once the build that supports webauthn is out.