Skip to content

Conversation

Bewinxed
Copy link
Collaborator

@Bewinxed Bewinxed commented Sep 25, 2025

What kind of change does this PR introduce?

Enhancement + Small bug fix
Add tests for the webauthn factorType and its (de)serialization/merging helpers.
Fix fallback naming for the credential when no friendlyname is provided and the username is null

What is the current behavior?

The factorId parameter was being sent in both the URL path and the request body when calling the MFA challenge endpoint, which could cause issues with the API.

No tests for factorType webauthn

What is the new behavior?

  • Destructured factorId from params in the _challenge method to only include it in the URL path, not the request body
  • Added tests for serialization/deserialization.
  • Added WebAuthn helper tests to validate merge operations
  • Configured docker-compose.yml with WebAuthn environment variables for local testing

Additional context

We still need to bump the /auth version in the dockor-compose.yml once the build that supports webauthn is out.

Copy link
Contributor

github-actions bot commented Sep 25, 2025

🚀 Preview Release Status

false


Last updated: 2025-10-03T21:08:39Z

@Bewinxed Bewinxed force-pushed the bewinxed/webauthn-add-tests branch from 2e210fd to 750d280 Compare September 25, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant