This repository was archived by the owner on Oct 10, 2025. It is now read-only.
fix: make webauthn param optional in .authenticate() and .register() and move register params to webauthn: object for consistency #1125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix / API improvement
What is the current behavior?
The
webauthn
parameter in the_authenticate()
method is required, and the_register()
method has WebAuthn-related parameters (rpId
,rpOrigins
,signal
) at the top level instead of being grouped under awebauthn
object.What is the new behavior?
webauthn
parameter optional in_authenticate()
method with default empty object fallback_register()
method into awebauthn
object for consistency with_authenticate()
webauthn
parameterAdditional context
None.