Skip to content

fix: Move @solana/wallet-standard-features to dependencies #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s-bridges
Copy link

@s-bridges s-bridges commented Jun 30, 2025

What kind of change does this PR introduce?

Bug fix - corrects dependency classification

What is the current behavior?

TypeScript compilation fails for users with the error:

Cannot find module '@solana/wallet-standard-features' or its corresponding type declarations

This happens because @solana/wallet-standard-features is imported in src/lib/types.ts but is incorrectly placed in devDependencies. When users install @supabase/auth-js, they don't get dev dependencies, causing the TypeScript compiler to fail when it encounters the missing module.

What is the new behavior?

TypeScript compilation works correctly. The @solana/wallet-standard-features package is now properly classified as a runtime dependency, making it available to all users who install @supabase/auth-js.

Users no longer need to manually install the missing dependency as a workaround.

Additional context

@s-bridges s-bridges changed the title Fix: Move @solana/wallet-standard-features to dependencies fix: Move @solana/wallet-standard-features to dependencies Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript compilation fails: @solana/wallet-standard-features in wrong dependency section
1 participant