refactor: change the bucket return error type #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Pozo <jackgris2@gmail.com>
| } | ||
|
|
||
| type MessageResponse struct { | ||
| Message string `json:"message"` | ||
| } | ||
|
|
||
| type BucketResponseError struct { | ||
| Error string `json:"error"` | ||
| Errors string `json:"error"` |
There was a problem hiding this comment.
I believe it is better to retain it as error because, given the multitude of errors, it should be an array of strings or structs.
|
This was fixed with the pull request #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Example to manage Bucket errors in a different way.
What is the current behavior?
Related to the issue #17
What is the new behavior?
The idea is to remove "panics" and return a custom error that satisfies the error interface.