Skip to content

chore: move insert_header to client #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2021
Merged

chore: move insert_header to client #27

merged 1 commit into from
May 15, 2021

Conversation

soedirgo
Copy link
Collaborator

Continuation of #26.

@gatewaynode let me know if this looks good to you, then I'll release a new version.

Copy link
Contributor

@gatewaynode gatewaynode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good change and using IntoHeaderName beats the explicit static str I was using.

@soedirgo soedirgo merged commit 8d645ca into master May 15, 2021
@soedirgo soedirgo deleted the chore/header branch May 15, 2021 02:22
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants