Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
5707bb8
pickin up fast
juleswritescode Nov 7, 2025
8b96f00
so far
juleswritescode Nov 8, 2025
799f52d
changie
juleswritescode Nov 8, 2025
f8ca407
readied
juleswritescode Nov 8, 2025
6365f80
more removed
juleswritescode Nov 8, 2025
4324377
minor changes
juleswritescode Nov 8, 2025
9586d8c
Update crates/pgls_completions/src/relevance/filtering.rs
juleswritescode Nov 8, 2025
c3201e7
use indoc, add setup
juleswritescode Nov 9, 2025
cbbe1f2
Merge branch 'feat/completions-test-suite' of https://github.com/supa…
juleswritescode Nov 9, 2025
09664c1
ok
juleswritescode Nov 9, 2025
853929c
many fixings
juleswritescode Nov 22, 2025
ad45958
Merge branch 'main' of https://github.com/supabase-community/postgres…
juleswritescode Nov 22, 2025
0a9be8a
remove all commata?
juleswritescode Nov 22, 2025
6fabed2
use current version of bun
juleswritescode Nov 22, 2025
cdb4355
Merge branch 'feat/completions-test-suite' of https://github.com/supa…
juleswritescode Nov 22, 2025
c0e2d35
fixed aaaaaaaaaaaaaaat
juleswritescode Nov 22, 2025
324c4f5
commit
juleswritescode Nov 22, 2025
9c07d91
accept snaps
juleswritescode Nov 22, 2025
359a8ff
ok?
juleswritescode Nov 22, 2025
195c706
do not prefer public schema
juleswritescode Nov 22, 2025
9f8435f
more adjustments
juleswritescode Nov 22, 2025
61b02ff
snaps
juleswritescode Nov 22, 2025
0dc7f2b
ok
juleswritescode Nov 22, 2025
46c2596
slight improvement
juleswritescode Nov 22, 2025
faf3793
intermediary
juleswritescode Nov 29, 2025
f55386a
merged
juleswritescode Dec 12, 2025
4cf53b4
many changes
juleswritescode Dec 12, 2025
cf0c98d
this is gret
juleswritescode Dec 12, 2025
21217b5
commitered
juleswritescode Dec 13, 2025
0accdf2
many cheeeenges
juleswritescode Dec 13, 2025
f8daaf3
fix: rest of tests
juleswritescode Dec 13, 2025
7ce97c6
removed many stuffs
juleswritescode Dec 13, 2025
9e29117
squieliex
juleswritescode Dec 13, 2025
2f97f7f
readied
juleswritescode Dec 13, 2025
db53efd
Merge branch 'main' of https://github.com/supabase-community/postgres…
juleswritescode Dec 13, 2025
d4e8b48
only install if no cache
juleswritescode Dec 13, 2025
71969bb
rename test bin?
juleswritescode Dec 13, 2025
c484d0b
that one, too
juleswritescode Dec 13, 2025
a6cbde6
aha!
juleswritescode Dec 13, 2025
78cecce
remove depr tests
juleswritescode Dec 13, 2025
0068c2a
disable-db
juleswritescode Dec 13, 2025
87925f2
clean
juleswritescode Dec 13, 2025
c4e5747
ack
juleswritescode Dec 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
this is gret
  • Loading branch information
juleswritescode committed Dec 12, 2025
commit cf0c98debabde55f2068a80e3571374c4784f208
3 changes: 2 additions & 1 deletion crates/pgls_completions/src/providers/columns.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ fn get_completion_text(ctx: &TreesitterContext, col: &Column) -> CompletionText

#[cfg(test)]
mod tests {
use pgls_test_utils::QueryWithCursorPosition;
use sqlx::PgPool;

use crate::test_helper::{TestCompletionsCase, TestCompletionsSuite};
use crate::test_helper::{TestCompletionsCase, TestCompletionsSuite, assert_complete_results};

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
async fn handles_nested_queries(pool: PgPool) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,16 @@ b - public.others.b (Column)
--------------

insert into instruments (i|, name) values ('my_bass');

Results:
id - public.instruments.id (Column)
ident - pg_catalog.pg_backend_memory_contexts.ident (Column)
identity_cycle - information_schema.columns.identity_cycle (Column)
identity_generation - information_schema.columns.identity_generation (Column)
identity_increment - information_schema.columns.identity_increment (Column)

--------------

insert into instruments (id, |, name) values ('my_bass');
**`name` is already written, so z should be suggested.**

Expand Down
21 changes: 20 additions & 1 deletion crates/pgls_treesitter/src/context/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,11 @@ impl<'a> TreesitterContext<'a> {
ctx.gather_tree_context();
ctx.gather_info_from_ts_queries();

println!("{} {:#?}", ctx.text, ctx.get_node_under_cursor_content(),);
println!("TreesitterContext: {:#?}", ctx);
println!(
"NodeUnderCursor: {:#?}",
ctx.get_node_under_cursor_content()
);

ctx
}
Expand Down Expand Up @@ -359,6 +363,10 @@ impl<'a> TreesitterContext<'a> {
}
}

"insert_columns" => {
self.wrapping_node_kind = Some(WrappingNode::List);
}

_ => {
if let Some(clause_type) =
self.get_wrapping_clause_from_current_node(current_node, &mut cursor)
Expand All @@ -372,6 +380,17 @@ impl<'a> TreesitterContext<'a> {
if current_node.child_count() == 0
|| current_node.first_child_for_byte(self.position).is_none()
{
// if the cursor is exactly at the start of a punctuation node,
// prefer the previous sibling (e.g., when cursor is at "i|," prefer "i" over ",")
let is_punctuation = matches!(current_node.kind(), "," | ")" | ";");
if is_punctuation && current_node.start_byte() == self.position {
if let Some(prev) = current_node.prev_sibling() {
if prev.end_byte() == self.position {
self.node_under_cursor = prev;
return;
}
}
}
self.node_under_cursor = current_node;
return;
}
Expand Down
Loading