Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject line should show topic from newest message - eMBee's idea 3 #384

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tradzik
Copy link

@tradzik tradzik commented Jan 18, 2015

@eMBee
Copy link
Contributor

eMBee commented Jan 18, 2015

i love this one, when it's working. some issues:
you seem to pick the last message in the list, but when i open the thread, sup shows me the last message by date (i think)
also, when there are unread messages, it will show me the first unread message.
the subject shown should be the one from the message that sup will open.

to fix: figure out how sup decides which message to open and find out how to get the subject of that message.

def find_last
ret = nil
find_all { |e| ret = yield(e) }
ret || nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nil or nil?

@gauteh
Copy link
Member

gauteh commented Jan 18, 2015

Not sure if I fully support this idea, what if someone picks up an old thread from a mailinglist, modifies the subject and then sends a reply... also, is not the original subject best? Otherwise it might be more difficult to find an old thread and keep track of which is which (for the user).

@eMBee
Copy link
Contributor

eMBee commented Jan 18, 2015

it is debatable.
if i want to find a newer topic, it is equally dificult to find now. so which one is more important? old topic or new?

the problem for me is, if i read a thread, and i found i don't care about it, but then the subject changes, i want to know about it
in other words, i want to know the subject i am currently going to be reading.
an alternative is to break treads every time the subject changes. that can be useful because some threads can become huge, and are a pain to use.
i also have problems with mails from jenkins which reports the build status in the subject. and all messages end up in a thread. that is useful, because it declutters my mailbox, but the old subject is useless. i need to see the newest one.

@gauteh
Copy link
Member

gauteh commented Jan 18, 2015

You will now about it because there is a new message, thread splitting on subjects does not make so much sense. That would change the way the threading in the index is built up. There is a hook for the date widget, maybe making a hook for the subject widget would be a better option?

@eMBee
Copy link
Contributor

eMBee commented Jan 18, 2015

just having a new message doesn't tell me enough. the problem is, that i don't know if the message is the same old subject i am not interested in, or if the subject has changed.

do you mean a hook to make the subject configurable? that could be interesting...

@gauteh
Copy link
Member

gauteh commented Jan 18, 2015

Excerpts from eMBee's message of January 18, 2015 15:57:

just having a new message doesn't tell me enough. the problem is, that
i don't know if the message is the same old subject i am not
interested in, or if the subject has changed.

do you mean a hook to make the subject configurable? that could be
interesting...

Yes, please have a look at the date-widget and size-widget hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants