Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 1 from eMBee list - changed usage of sup@fake.sender.example.com address while replying #376

Open
wants to merge 38 commits into
base: develop
Choose a base branch
from

Conversation

tradzik
Copy link

@tradzik tradzik commented Jan 10, 2015

https://factor.cc/pad/p/sup-ideas - details about issue

@eMBee ping

@gauteh
Copy link
Member

gauteh commented Jan 12, 2015

@ty221: Please start using a descriptive title in the header of the pull request as well as more information in the description. Please update the your other PR / issues as well.

@tradzik tradzik changed the title Fixed issue 1 from eMBee list Fixed issue 1 from eMBee list - changed usage of sup@fake.sender.example.com address while replying Jan 12, 2015
@tradzik
Copy link
Author

tradzik commented Jan 12, 2015

@gauteh Done

@eMBee
Copy link
Contributor

eMBee commented Jan 17, 2015

this seems to work, except for cases where the From: header is missing completely. in that case a reply has an empty To: field

@tradzik
Copy link
Author

tradzik commented Jan 17, 2015

@eMBee can't reproduce. When From in header is missing and there is only one recepient (me), it shows only customized view. Where there are multiple people, it shows two views: customized and recepient. Customized is empty, recepient imports emails propely

@eMBee
Copy link
Contributor

eMBee commented Jan 18, 2015

try with a different recipient, not you. try with multiple recipents in the To: header

@gauteh
Copy link
Member

gauteh commented Jan 18, 2015

I think name = "Sup Auto-generated Fake Sender <sup@fake.sender.example.com> in message.rb should be made a class constant (split into name and email) and then referenced in that way both in message.rb and in your code, also, it would be nice to grep the rest of the code base to see if it should be replaced somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants