Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: gif window size #217

Closed
Orycterope opened this issue Mar 14, 2019 · 0 comments
Closed

shell: gif window size #217

Orycterope opened this issue Mar 14, 2019 · 0 comments
Assignees
@Orycterope
Labels
project-shell Related to the shell type-bug Something isn't working

Comments

@Orycterope
Copy link
Member

When displaying a meme, create a window the size of the gif to be displayed, instead of the size of the screen, as the gif might be bigger than screen and this causes a panic when slice indexing.

This way, if a gif is too big, vi will crop it for us, as expected.
@Orycterope Orycterope self-assigned this Mar 14, 2019
@Orycterope Orycterope added type-bug Something isn't working project-shell Related to the shell labels Mar 14, 2019
Orycterope added a commit to Orycterope/SunriseOS that referenced this issue Mar 14, 2019
@Orycterope
shell: gif window size
748d082 
When displaying a GIF, create a window the size of the gif.

Fixes sunriseos#217
@Orycterope Orycterope mentioned this issue Mar 14, 2019
Merged
roblabla pushed a commit to roblabla/KFS that referenced this issue Mar 16, 2019
@Orycterope @roblabla
shell: gif window size
452b61a 
When displaying a GIF, create a window the size of the gif.

Fixes sunriseos#217
roblabla pushed a commit to roblabla/KFS that referenced this issue Mar 16, 2019
@Orycterope @roblabla
shell: gif window size
b7ebdf4 
When displaying a GIF, create a window the size of the gif.

Fixes sunriseos#217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Orycterope Orycterope

Labels
project-shell Related to the shell type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Orycterope