Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfsspy to sunkit-magex #403

Closed
nabobalis opened this issue Mar 1, 2024 · 4 comments
Closed

pfsspy to sunkit-magex #403

nabobalis opened this issue Mar 1, 2024 · 4 comments
Assignees
Labels
Affiliated Package Review An issue submitting a new Affiliated Package for review

Comments

@nabobalis
Copy link
Contributor

Do we need to review or can we rename the package and go from there?

@nabobalis nabobalis added the Affiliated Package Review An issue submitting a new Affiliated Package for review label Mar 1, 2024
@Cadair
Copy link
Member

Cadair commented Mar 1, 2024

I would suggest we mark pfsspy as dead, and review magex. I feel like we should go though the process even if it's own own package with minimal new code. (we want to look like we are doing things properly here).

@nabobalis
Copy link
Contributor Author

Then we should get someone to review it.

@Cadair
Copy link
Member

Cadair commented Jun 9, 2024

Ok, this shouldn't be hard, and I haven't actually written it so here is the review for magex:

Package Details

Description of Package

A magnetic field extrapolation package spun out of pfsspy.

Package Review

Editor Submission Checklist

  • Is the submission appropriate (compatible with the SunPy CoC)?
  • Does the project have an appropriate license?
  • Is the project in an online version control system?
  • Does the project provide a Python interface?
  • Is the project on PyPI?
  • Is the project useful to the solar physics community?
  • Version that was reviewed (tag or commit hash) 1.0.0(rc1)

@Cadair
Copy link
Member

Cadair commented Jun 9, 2024

  • Functionality :
  • Integration : Partial Integration
  • Documentation : Extensive
  • Testing : Excellent
  • Duplication : None
  • Community : Excellent
  • Development Status : Stable

Cadair added a commit to Cadair/sunpy.org that referenced this issue Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affiliated Package Review An issue submitting a new Affiliated Package for review
Projects
None yet
Development

No branches or pull requests

2 participants