Adding citing sunpy to navbar #284
Conversation
src/sunpy_sphinx_theme/__init__.py
Outdated
| @@ -58,6 +58,7 @@ def default_navbar(): | |||
| ("Get Help", "help/", 2), | |||
| ("Contribute", "contribute/", 2), | |||
| ("Blog", "blog/", 2), | |||
| ("Citing SunPy", "https://docs.sunpy.org/en/stable/citation.html", 3), | |||
There was a problem hiding this comment.
I'm a little reluctant to add more stuff to the very top level of the navbar, there's a practical limit to the number of things we can have before the nav bar starts looking wrong on certain screen widths.
There was a problem hiding this comment.
i totally get that - but I think having it prominent across the templates would be good?
There was a problem hiding this comment.
or any other suggestion about where to put it?
There was a problem hiding this comment.
We could move affiliated packages under about?!
There was a problem hiding this comment.
hmm i dont know, its also good to have that on the landing page with an easy button?
There was a problem hiding this comment.
does adding "Citing SunPy" here go beyond the practical limit ? i think its worthy here no?
There was a problem hiding this comment.
yes, this happens below 1082 pixels wide:
There was a problem hiding this comment.
We can attempt to fix this bug rather than work around it with less things of course.
Fixes sunpy/sunpy.org#438 and adds an easy link to cite sunpy to the navbar